Uploaded image for project: 'DC/OS'
  1. DC/OS
  2. DCOS_OSS-1007

Admin Router: Improve /metadata endpoint `detect_ip_public` script call error handling

    Details

      Description

      `/metadata` location calls to `detect_ip_public` script: https://github.com/dcos/dcos/blob/master/packages/adminrouter/extra/src/master/metadata.lua#L3-L5

      Unfortunately, the error handling could be improved as we currently:

      • do not verify that the exit code of the script is `0`
      • script call does not timeout, and to make matter worse - it's a blocking call

      Things we can use:

      Tests marked as xfail are being introduced in https://github.com/dcos/dcos/pull/1487

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              prozlach Pawel Rozlach
              Team:
              Mesosphere
              Watchers:
              Jan-Philip Gehrcke (Inactive), Pawel Rozlach
            • Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: