Uploaded image for project: 'DC/OS'
  1. DC/OS
  2. DCOS_OSS-946

Fix padding on icons inside buttons

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: DC/OS 1.12.0
    • Component/s: None
    • Labels:

      Description

      With the latest update to React, text nodes are no longer implicitly wrapped in span tags. CNVS makes some naive assumptions about the contents of buttons, giving all children padding-right, except for the last child. This effectively means that all icons in buttons (e.g. the "Add" and "Advanced" buttons in our service create form) no longer have the padding.

      Let's figure out a good solution to this and write an integration test!

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              johnf John Furrow (Inactive)
              Team:
              DELETE Frontend (Mesosphere) Team
              Watchers:
              John Furrow (Inactive), Orlando Hohmeier (Inactive)
            • Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Zendesk Support

                  NextupJiraPlusStatus

                  Error rendering 'slack.nextup.jira:nextup-jira-plus-status'. Please contact your JIRA administrators.