[DCOS_OSS-946] Fix padding on icons inside buttons Created: 13/Apr/17 Updated: 09/Nov/18 Resolved: 10/Sep/18
|Fix Version/s:||DC/OS 1.12.0|
|Reporter:||John Furrow (Inactive)||Assignee:||Unassigned|
|Remaining Estimate:||Not Specified|
|Time Spent:||Not Specified|
|Original Estimate:||Not Specified|
|Team:||DELETE Frontend (Mesosphere) Team|
With the latest update to React, text nodes are no longer implicitly wrapped in span tags. CNVS makes some naive assumptions about the contents of buttons, giving all children padding-right, except for the last child. This effectively means that all icons in buttons (e.g. the "Add" and "Advanced" buttons in our service create form) no longer have the padding.
Let's figure out a good solution to this and write an integration test!