[DCOS_OSS-946] Fix padding on icons inside buttons Created: 13/Apr/17  Updated: 09/Nov/18  Resolved: 10/Sep/18

Status: Resolved
Project: DC/OS
Component/s: None
Affects Version/s: None
Fix Version/s: DC/OS 1.12.0

Type: Bug Priority: Medium
Reporter: John Furrow (Inactive) Assignee: Unassigned
Resolution: Done  
Labels: frontend
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Team: DELETE Frontend (Mesosphere) Team


With the latest update to React, text nodes are no longer implicitly wrapped in span tags. CNVS makes some naive assumptions about the contents of buttons, giving all children padding-right, except for the last child. This effectively means that all icons in buttons (e.g. the "Add" and "Advanced" buttons in our service create form) no longer have the padding.

Let's figure out a good solution to this and write an integration test!

Generated at Tue May 24 04:25:41 CDT 2022 using JIRA 7.8.4#78004-sha1:5704c55c9196a87d91490cbb295eb482fa3e65cf.